Repository navigation
fix: export Ranked from the prelude - #1621
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
devin-ai-integration
Bot
force-pushed
the
ranked-prelude
branch
from
October 18, 2026 22:26
1650760 to
930501c
Compare
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1575 moved
ndimoff ofDimensionand onto the newRankedsupertrait. Generic code with aD: Dimensionbound still works, but calling.ndim()on a concrete dimension type now needsRankedin scope, so this stopped compiling:This exports
Rankedfrom the prelude next toDimension. Code that importsndarray::Dimensiondirectly, rather than going through the prelude, still has to importndarray::layout::ranked::Rankedtoo.CI is red until #1622 lands. That PR fixes lints from newer toolchains that also fail on
refactoritself.Link to Devin session: https://app.devin.ai/sessions/4b52e943e29a466ea652d856b7f556c4
Open in Devin Desktop: https://app.devin.ai/desktop/session/4b52e943e29a466ea652d856b7f556c4?variant=devin
Requested by: @akern40